1.2.10 breaks Travis builds

[Majkl578]

Hello.
as1.2.10 was released today, it started breaking Travis builds using this extension from PECL.
This is caused by BC break in cbb5f9f which addresses API/ABI break in PHP 7.2 RC phase introduced in php/php-src@bdd56f3#diff-05931d95f4541dc2f528625e662a307c.
Travis is still running on PHP 7.2.0beta3 and this extension fails to compile there.
Here's a failing job for Doctrine: https://travis-ci.org/doctrine/data-fixtures/jobs/273067384#L1141

[jmikola]

I can look into amending the conditional in cbb5f9f to differentiate between PHP 7.2 RC1 and earlier versions, but I think it would be worthwhile to request that Travis CI upgrade their PHP 7.2 environment to RC1 (if you've not already done so).

As an aside, I imagine we have a number of internal PHP version checks that may fail on historic beta versions.

[Majkl578]

Well, Travis is not that fast with updating versions. There is already a PR for newer version here: php-build/php-build#474. But until it gets merged, binaries rebuilt and distributed, this is unfortunately a blocker (although PHP 7.2 is still not GA).

As an aside, I imagine we have a number of internal PHP version checks that may fail on historic beta versions.

World would be much happier place if there were no BC breaks in beta/RC versions... 😐

[jmikola]

Tracking in PHPC-1009.

[jmikola]

@Majkl578: I spoke with @derickr about the timelib change and he pointed out that TIMELIB_VERSION is not suitable to use for checking ABI (see: #652 (comment)). Rather than create a 1.2.11 release with a hackish workaround, and then revert that with a later 1.2.12 release, I'd like to wait this out until Travis CI is updated to 7.2 RC1.

I see that php-build/php-build#474 was merged over the weekend, so hopefully that update will be imminent.

[jmikola]

Travis is now using PHP 7.2 RC1, so I will resolve this.

[Majkl578]

Awesome, sorry for extra work and thanks!