PHPC-1346: Do not allow empty string for username #1012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
phpc-1346
branch
2 times, most recently
from
d91717a to
068b62b
Compare
jmikola
reviewed
Aug 22, 2019
jmikola
approved these changes
Aug 25, 2019
|
Suggested test addition, but LGTM either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1346
Since libmongoc does validation in
mongoc_uri_parse, passing a username asoptioninMongoDB\Driver\Manager::constructeffectively bypasses sanity checks on the authentication options. Since the check can't be done inmongoc_uri_set_usernamebecause the authentication options may change later, we have to replicate the sanity checks frommongoc_uri_finalize_authhere.