PHPC-1431, PHPC-1435: Fix Session::startTransaction() param and arginfo

[jmikola]

https://jira.mongodb.org/browse/PHPC-1431
https://jira.mongodb.org/browse/PHPC-1435

[alcaeus]

LGTM. The signature claims a default value of null, so this makes sense. You could add a test to explicitly pass null to the method, but it's also fine without one.

[jmikola]

You could add a test to explicitly pass null to the method, but it's also fine without one.

I checked if we had any other phpt tests for passing null to option array params elsewhere and didn't find any. Not sure that's worth a ticket to go and add tests for every method.

Side note: the proto comments above each method are purely for internal documentation. The important data is actually the method's arg info, which I just realized is incorrect. That is relevant for querying the extension API via Reflection

[jmikola]

Note to self: reference PHPC-1435 in second commit before merging.

[alcaeus]

The important data is actually the method's arg info, which I just realized is incorrect.

After double-checking, I should've seen that. I checked the ZEND_ARG_INFO call and didn't see anything about it being optional or not. ZEND_ARG_ARRAY_INFO makes more sense 👍

[alcaeus]

@jmikola I've taken the liberty of amending your commit message and fixing the failing test. Since the behaviour will be different on PHP 5 and PHP 7, I've split the test.

[jmikola]

I appear to be unable to approve my own pull request, but LGTM just the same.

[jmikola]

I find it very interesting that the arg info is what actually changed behavior here. This suggests that PHP might raise the TypeError before the method is even called (perhaps similar to how type hints would be checked in userland code).

PHP 7.x apparently used to emit a warning just like PHP 5 in the original version of session-startTransaction_error-003.phpt, and I expect that probably originated in the zend_parse_parameters() call. Perhaps @sgolemon can confirm if this is an accurate assessment.

[jmikola]

Can I get a "what what" for object calisthenics 🙌