Skip to content

PHPC-1449: Resync bson-corpus tests to fix duplicate test names #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2019
Merged

PHPC-1449: Resync bson-corpus tests to fix duplicate test names #1039

merged 1 commit into from
Oct 17, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Oct 10, 2019

@alcaeus alcaeus requested a review from jmikola October 10, 2019 09:13
@alcaeus alcaeus self-assigned this Oct 10, 2019
jmikola
jmikola approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you figured out the conversion script just fine on your own :)

alcaeus added a commit that referenced this pull request Oct 17, 2019
@alcaeus
Merge pull request #1039
fbbe54a
@alcaeus alcaeus merged commit 48329b4 into mongodb:master Oct 17, 2019
@alcaeus alcaeus deleted the phpc-1449 branch October 17, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmikola jmikola jmikola approved these changes

Assignees

@alcaeus alcaeus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alcaeus @jmikola