PHPC-1497: Introduce new configure switch to use system libraries #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a custom path is easily managed by setting PKG_CONFIG_PATH LGTM |
|
lgtm too |
|
Thank you for the quick feedback! ❤️ |
jmikola
reviewed
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1497
The new
--with-system-libsconfigure switch replaces--with-libmongocand--with-libbson, since they both needed to have the same value. Passing--with-system-libs=yeswill always compile against system libraries, regardless of the--with-libmongocand--with-libbsonoptions. When one of these two options is used, a message is printed alerting the user that the settings are deprecated and they should use--with-system-libsinstead.Since neither libmongoc nor libbson option took a path where to find the libraries, it is better to use this compound switch. However, if downstream packages need to supply custom paths for libbson or libmongoc, we may opt to keep the individual options instead. Ping @remicollet and @oerdnj for feedback on this.