PHPC-1529: Reset libmongocrypt key vault client after forking #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Jan 18, 2021
jmikola
reviewed
Jan 18, 2021
jmikola
approved these changes
Jan 18, 2021
jmikola
requested changes
Jan 20, 2021
jmikola
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-1529
Fixing this in master to take advantage of the new disableClientPersistence option for tests. The test was a bit tricky to write, but I managed to verify that the keyVaultClient is reset by triggering a reset on the client (by running a query in the fork), then trying to iterate a cursor that was previously opened on the keyVaultClient. With the additional call to
php_phongo_client_reset_onceremoved, this test fails as expected.