Skip to content

PHPC-409: Compatibility updates for libmongoc 1.2.0-rc0 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 5, 2015
Merged

PHPC-409: Compatibility updates for libmongoc 1.2.0-rc0 #119

merged 10 commits into from
Oct 5, 2015

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Oct 2, 2015

This also incorporates commits from #101 and #105.

Note that the following tests will still fail until CDRIVER-903 is resolved (tracking in PHPC-441):

  • tests/server/server-executeCommand-002.phpt
  • tests/server/server-executeQuery-005.phpt

This was referenced Oct 2, 2015
Closed
Closed
bjori
bjori reviewed Oct 2, 2015
View reviewed changes
config.m4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct and will make #104 broken.

Please include all files. If the file was renamed, please use the new name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, we also need the mongoc-version-functions.c added to MONGOC_SOURCES (it was never included). I'll fix both.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. mongoc-version-functions.c is also a new file in the rc0 and needs to be included

@bjori
Copy link
Contributor

bjori commented Oct 2, 2015

Note that the following tests will still fail until CDRIVER-903 is resolved:

Remember to include a PHPC tracking ticket for it, otherwise it might get fixed, but the test still failing for other reason, but will be ignored forever as "assumed to be CDRIVER-903" issue.

@jmikola jmikola force-pushed the libmongoc-1.2.0-rc0 branch from 53c7aaf to 2c46a41 Compare October 4, 2015 05:48
@jmikola
Copy link
Member Author

jmikola commented Oct 4, 2015

Remember to include a PHPC tracking ticket for it, otherwise it might get fixed, but the test still failing for other reason, but will be ignored forever as "assumed to be CDRIVER-903" issue.

Added PHPC-441 to the OP.

@jmikola jmikola force-pushed the libmongoc-1.2.0-rc0 branch from 2c46a41 to c23c6d4 Compare October 4, 2015 06:18
@jmikola jmikola force-pushed the libmongoc-1.2.0-rc0 branch from c23c6d4 to 069739e Compare October 5, 2015 16:26
@remicollet remicollet mentioned this pull request Oct 5, 2015
Closed
@jmikola jmikola force-pushed the libmongoc-1.2.0-rc0 branch from 522dceb to 968dbd8 Compare October 5, 2015 19:48
@jmikola jmikola force-pushed the libmongoc-1.2.0-rc0 branch from 968dbd8 to 31661a3 Compare October 5, 2015 20:15
@bjori
Copy link
Contributor

bjori commented Oct 5, 2015

lgtm

@jmikola jmikola merged commit 31661a3 into mongodb:master Oct 5, 2015
jmikola added a commit that referenced this pull request Oct 5, 2015
@jmikola
Merge pull request #119
9458df3
@jmikola jmikola deleted the libmongoc-1.2.0-rc0 branch October 5, 2015 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmikola @bjori