Skip to content

PHPC-1737: Use zend_hash_graceful_reverse_destroy for persistent client HashTable #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2021
Merged

PHPC-1737: Use zend_hash_graceful_reverse_destroy for persistent client HashTable #1191

merged 2 commits into from
Jan 20, 2021

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Jan 20, 2021 •
edited
Loading

https://jira.mongodb.org/browse/PHPC-1737

Also includes a second commit improving the comments for request-scoped HashTables.

I manually tested that zend_hash_graceful_destroy causes a segfault for keyVaultClient tests, so we can be certain that zend_hash_graceful_reverse_destroy is doing its job.

@jmikola jmikola requested a review from alcaeus January 20, 2021 06:27
alcaeus
alcaeus approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for expanding the comments to add more explanation about freeing resources!

@jmikola jmikola merged commit 69efd5c into mongodb:master Jan 20, 2021
@jmikola jmikola deleted the phpc-1737 branch January 20, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmikola @alcaeus