PHPC-1748 Fix wrong return value of Cursor::key when iterator is not valid #1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Jan 21, 2021
src/MongoDB/Cursor.c
Outdated
| ZVAL_NULL(key); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Since you introduced the Iterator methods, it looks like php_phongo_cursor_get_current_key and php_phongo_cursor_get_current_data are only called from key() and current(), respectively. Can we just delete these two functions?
That would allow you to move this logic into key(), which would be consistent with what you did for current() in 70a097e.
There was a problem hiding this comment.
Sure, I can refactor this 👍
jmikola
reviewed
Jan 22, 2021
jmikola
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-1748