PHPC-2220: Return int64 values for server connection ID #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to BC constraints, we can't return 64-bit values on 32-bit platforms. On those platforms, the value will be truncated and an E_WARNING is raised to inform the user.
jmikola
approved these changes
May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2220
Also fixes PHPC-1941 (using OP_MSG to authenticate if the server supports it) by using the new libmongoc version.
Due to BC constraints, the API of
getServerConnectionIdin the command events can't be changed and we're forced to return an int value here. For that reason, the methods now raise anE_WARNINGif a 64-bit value is truncated on a 32-bit platform. This is in line with previous behaviour, where the value was also truncated. Values within the 32-bit range and all values on 64-bit platforms will be returned as integers.