Skip to content

PHPC-1000: Add missing exception #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023
Merged

PHPC-1000: Add missing exception #1453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/phongo_bson_encode.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ static inline bool phongo_check_bson_serialize_return_type(zval* retval, zend_cl
return true;
}

phongo_throw_exception(PHONGO_ERROR_UNEXPECTED_VALUE,
"Expected to receive instance of %s, %s given",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation looks way off here. Did you run this through clang-format?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed by CLion when I moved code around. clang-format doesn't care about these indentations, but we typically only indent an additional level for multi-line method calls. I've updated this and two other instances in this file.

ZSTR_VAL(php_phongo_serializable_ce->name),
ZSTR_VAL(ce->name));
return false;
}

Expand Down