Skip to content

Use php/setup-php-sdk #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Use php/setup-php-sdk #1497

wants to merge 3 commits into from

Conversation

derickr
Copy link
Contributor

@derickr derickr commented Nov 29, 2023

No description provided.

@alcaeus
Copy link
Member

alcaeus commented Nov 29, 2023

Yay! Can you rebase this to target the v1.17 stable branch so it also applies to future 1.17 patch releases?

@jmikola jmikola changed the base branch from master to v1.17 November 30, 2023 21:15
@jmikola
Copy link
Member

jmikola commented Nov 30, 2023

Can you rebase this to target the v1.17 stable branch so it also applies to future 1.17 patch releases?

I just changed the PR target but it looks like @derickr might have to actually rebase and force push. Doing so via the GitHub UI would likely leave the master is now 1.18-dev commit in place.

alcaeus and others added 3 commits November 30, 2023 20:57
* Exclude 5.0 from test-debian11-php82 build variant

This was missed in a204130

* Add line breaks between build variants

* Remove "local" from build variant names
jmikola added a commit that referenced this pull request Dec 1, 2023
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
@jmikola
Copy link
Member

jmikola commented Dec 1, 2023

I manually merged this PR in c45092b and subsequently merged v1.17 up to master in 5ffd929.

@jmikola jmikola closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants