PHPC-629: Resolve mongoc-cursor-cursorid memory leaks #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -402,6 +402,10 @@ PHP_ARG_WITH(libmongoc, whether to use system libmongoc, | |||
| AC_SUBST(MONGOC_ENABLE_SECURE_TRANSPORT, 0) | |||
| AC_SUBST(MONGOC_ENABLE_COMMON_CRYPTO, 0) | |||
|
|
|||
| dnl Secure Channel only applies to Windows | |||
| AC_SUBST(MONGOC_ENABLE_SECURE_CHANNEL, 0) | |||
There was a problem hiding this comment.
Apologize upfront. This will be renamed very soon.
MONGOC_ENABLE_SSL_SECURE_CHANNEL
MONGOC_ENABLE_SSL_SECURE_TRANSPORT
MONGOC_ENABLE_SSL_OPENSSL
same with crypto
MONGOC_ENABLE_CRYPTO_COMMON_CRYPTO
MONGOC_ENABLE_CRYPTO_CNG
MONGOC_ENABLE_CRYPTO_LIBCRYPTO
There was a problem hiding this comment.
No problem. Thanks for the heads up!
I started this PR before realizing that only libbson was updated. I'll revisit once the upstream ticket is resolved in libmongoc.
jmikola
force-pushed
the
libmongoc-memleak
branch
from
1da9c4d to
3959597
Compare
jmikola
changed the title
This resolves a memory leak introduced in 12ec628.
jmikola
force-pushed
the
libmongoc-memleak
branch
from
3959597 to
38f7d67
Compare
jmikola
added a commit
that referenced
this pull request
Apr 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-629