PHPC-698, PHPC-699: Check HAVE_OPENSSL_EXT before calling php-ssl.c functions #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jmikola
commented
May 10, 2016
jmikola
commented
- https://jira.mongodb.org/browse/PHPC-698
- https://jira.mongodb.org/browse/PHPC-699
…iver php_phongo_verify_hostname() can also be static, since it is not used outside of php_phongo.c
|
LGTM |
|
Wouldn't you rather want to error out much earlier, say before calling php_phongo_ssl_verify (), if there are ssl context options set, while ssl is not enabled/available? |
|
@bjori: This PR is specific to the user compiling the extension without SSL but loading in a PHP runtime with SSL. I'm fine with keeping the error messages narrow around the code that would actually rely on these symbols. The user needn't be bothered if the stream options are disabled. The inverse case is if SSL isn't available at runtime. For that, the user would already get an exception during stream initialization and before we attempt to verify any certs or hostnames. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.