PHPC-239: Cursor refcount issues #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
php_phongo.c
Outdated
There was a problem hiding this comment.
Since this only frees cursor->visitor_data.zchild if it's not null, was there a specific reason to move it up? I've no objection if it was just for style points, but I'm curious if there was another reason.
There was a problem hiding this comment.
cursor_it->cursor is the php_phongo_cursor_t* of the cursor_it->intern.data zval*.
If you destroy the zval first, the php_phongo_cursor_t* will be invalid.
bjori
force-pushed
the
PHPc-239
branch
2 times, most recently
from
514366f to
11a57b4
Compare
tests/standalone/bug0239.phpt
Outdated
There was a problem hiding this comment.
This should be PHPC and omit the leading zero.
|
LGTM. |
This also fixes re-iterating over a cursor where we would not free the firstBatch properly, so the last result was still there.
bjori
added a commit
that referenced
this pull request
Apr 14, 2015
PHPC-239: Cursor refcount issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.