PHPC-939: Don't modify std props in BSON get_properties handlers #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derickr
suggested changes
Jul 10, 2017
src/BSON/ObjectID.c
Outdated
There was a problem hiding this comment.
This section is done for every class. Is it not possible to extract this into its own function? It would save a lot of boiler plate.
jmikola
commented
Jul 10, 2017
| (intern)->properties = (props); \ | ||
| } \ | ||
| } while(0); | ||
|
|
There was a problem hiding this comment.
@derickr: Refactored to use a macro. A function wasn't feasible since the type of intern varies with each class.
jmikola
added a commit
that referenced
this pull request
Jul 11, 2017
jmikola
added a commit
to jmikola/mongo-php-driver
that referenced
this pull request
Jan 9, 2018
This removes a call to zend_hash_clean() on successive calls to a BSON object's get_properties handler, which can lead to an infinite loop when iterating the object's properties with foreach on PHP 7.x. For historical reference, the original call to zend_hash_clean() was introduced in ad1f3f0 for mongodb#607 (PHPC-939).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-939