Skip to content

Conversation

derickr
Copy link
Contributor

@derickr derickr commented Dec 7, 2017

https://jira.mongodb.org/browse/PHPC-1017

Added the configurations to the package.xml.in file, and also align the options in ./configure --help (it's been bugging me for a while).

@derickr derickr requested a review from jmikola December 7, 2017 15:58
<extsrcrelease>
<configureoption name="with-libbson" default="no" prompt="Use system libbson"/>
<configureoption name="with-libmongoc" default="no" prompt="Use system libmongoc"/>
<configureoption name="with-openssl-dir" default="yes" prompt="OpenSSL dir for MongoDB"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a note that "yes" results in automatic detection?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "yes" (the binary) would also mean: system libbson, system libmongoc, and system-chiphers. I don't think we should recommend that?

<configureoption name="with-libbson" default="no" prompt="Use system libbson"/>
<configureoption name="with-libmongoc" default="no" prompt="Use system libmongoc"/>
<configureoption name="with-openssl-dir" default="yes" prompt="OpenSSL dir for MongoDB"/>
<configureoption name="with-system-ciphers" default="no" prompt="Use system default cipher list instead of hardcoded value"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may also warrant a note that it's for OpenSSL. Perhaps "OpenSSL: Use system default..."?

Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for config option docs, but LGTM otherwise.

@alcaeus: Note that you'll likely need to use yes for non-interactive PECL installs going forward, as PECL doesn't allow any way to avoid these prompts at install time.

@alcaeus
Copy link
Member

alcaeus commented Dec 7, 2017

@jmikola so in the future, it's yes | pecl install mongodb? Good thing it's 24pullrequests time :)

@jmikola
Copy link
Member

jmikola commented Dec 7, 2017

so in the future, it's yes | pecl install mongodb?

I think so. I recall having to do something similar when installing the legacy driver on Travis due to: https://github.com/mongodb/mongo-php-driver-legacy/blob/3321e9849a3d17503707ded728586ce34d69fb69/package.xml#L212-L214

@jmikola
Copy link
Member

jmikola commented Dec 8, 2017

Using "yes" (the binary) would also mean: system libbson, system libmongoc, and system-chiphers. I don't think we should recommend that?

@alcaeus: @derickr raised a good point above. I think we'll need to rework this a bit.

@derickr: I'm reminded that #659 was only asking about exposing --with-openssl-dir for use by Homebrew on macOS. That may be moot if PHPC-888 is implemented.

Copy link
Contributor Author

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rethink.

@derickr derickr closed this Jan 23, 2018
@derickr
Copy link
Contributor Author

derickr commented Jan 23, 2018

Won't Fix.

Copy link

@BJGDEV BJGDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants