Skip to content

Conversation

derickr
Copy link
Contributor

@derickr derickr commented Jan 10, 2018

No description provided.

@derickr derickr requested a review from jmikola January 10, 2018 15:35
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to remove $manager assignment, though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed.

@derickr derickr force-pushed the PHPC-1067-bson-regex-segfault-1.9.1-update branch from 5be038b to cb6d2c1 Compare January 10, 2018 16:39
@derickr derickr merged commit cb6d2c1 into mongodb:master Jan 10, 2018
derickr added a commit that referenced this pull request Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants