Skip to content

PHPC-1081: Package build failures on Fedora due to 32-bit issues, and it using MongoDB 3.4 #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 12, 2018
Merged

PHPC-1081: Package build failures on Fedora due to 32-bit issues, and it using MongoDB 3.4 #737

merged 8 commits into from
Jan 12, 2018

Conversation

derickr
Copy link
Contributor

@derickr derickr commented Jan 11, 2018

No description provided.

@derickr derickr force-pushed the PHPC-1081-32bit-issues branch from b9d9c75 to 809fd51 Compare January 11, 2018 16:02
@derickr derickr changed the title [WIP] PHPC-1081: Package build failures on Fedora due to 32-bit issues, and it using MongoDB 3.4 PHPC-1081: Package build failures on Fedora due to 32-bit issues, and it using MongoDB 3.4 Jan 11, 2018
jmikola
jmikola reviewed Jan 11, 2018
View reviewed changes
tests/bson/bson-timestamp_error-003.phpt Outdated
Copy link
Member

@jmikola jmikola Jan 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still going to produce an exception with "Expected increment to be an unsigned 32-bit integer, -2147483648 given" on 32-bit systems?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That's exactly what this test tests :-)

jmikola
jmikola reviewed Jan 11, 2018
View reviewed changes
tests/utils/tools.php Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short array syntax?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change that, if you really care :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do while merging. It'll just save time later if we come across it again and want to revise.

tests/apm/overview.phpt Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this test require a 64-bit platform?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cursor ID in one of the returned structures is 64-bit, and can't be represented in 32-bits :-/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at Remi's build log, I see:

Fatal error: Uncaught MongoDB\Driver\Exception\InvalidArgumentException: Integer overflow detected on your platform: 917 in /builddir/build/BUILD/php-pecl-mongodb-1.4.0~beta1/NTS/tests/apm/overview.php:17

If APM can't work on 32-bit, that may be a more general issue to look into. Outside the scope of this PR, though.

@derickr derickr force-pushed the PHPC-1081-32bit-issues branch from 809fd51 to 4334b00 Compare January 11, 2018 17:45
@remicollet
Copy link
Contributor

Still have 2 failed tests (1.4.0beta1 + this PR), only with 3.6 on 32-bit

MongoDB\Driver\Manager::executeReadCommand()
[tests/manager/manager-executeReadCommand-001.phpt]

004+ Fatal error: Uncaught MongoDB\Driver\Exception\RuntimeException:
Majority read concern requested, but it is not supported by the storage
engine. in
/builddir/build/BUILD/php-pecl-mongodb-1.4.0~beta1/NTS/tests/manager/manager-executeReadCommand-001.php:19

MongoDB\Driver\Server::executeReadCommand()
[tests/server/server-executeReadCommand-001.phpt]

004+ Fatal error: Uncaught MongoDB\Driver\Exception\RuntimeException:
Majority read concern requested, but it is not supported by the storage
engine. in
/builddir/build/BUILD/php-pecl-mongodb-1.4.0~beta1/NTS/tests/server/server-executeReadCommand-001.php:20

As 32-bit only supports mmapv1, can probably be skipped

@derickr derickr force-pushed the PHPC-1081-32bit-issues branch from 4334b00 to d0d3cc7 Compare January 12, 2018 11:55
@remicollet
Copy link
Contributor

Everything looks good now \o/

Thanks @derickr for this work.

@derickr derickr merged commit d0d3cc7 into mongodb:master Jan 12, 2018
derickr added a commit that referenced this pull request Jan 12, 2018
@derickr
Merged pull request #737
e51a184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmikola jmikola jmikola approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@derickr @remicollet @jmikola