Skip to content

PHPC-1098: Use exactly representable floats in tests #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

PHPC-1098: Use exactly representable floats in tests #740

wants to merge 1 commit into from

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Jan 19, 2018

@jmikola jmikola requested a review from derickr January 19, 2018 20:36
@jmikola
Copy link
Member Author

jmikola commented Jan 19, 2018

@derickr: I ran tests/bson in the Alpine Linux VM and verified that the previously failing tests now pass. That said, I did update more instances of floating points than were necessary with this PR.

In hindsight, it looks like the failures cited in PHPC-1098 were related to fromJSON rather than generic float handling in PHP.

derickr
derickr approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked PI better, but whatevs :-)

jmikola added a commit to jmikola/mongo-php-driver that referenced this pull request Jan 19, 2018
@jmikola
Merge pull request mongodb#740
687c359
@jmikola jmikola closed this Jan 19, 2018
@jmikola jmikola deleted the phpc-1098 branch January 19, 2018 22:19
@jmikola
Copy link
Member Author

jmikola commented Jan 19, 2018

Merged in 687c359.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@derickr derickr derickr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmikola @derickr