Skip to content

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Jan 22, 2018

https://jira.mongodb.org/browse/PHPC-1100

This addresses test failures when the driver is compiled without SSL.

Tested with ./configure --with-mongodb-ssl=no.

Note that unrecognized values (e.g. --with-mongodb-ssl=whatever) functions similarly to no:

checking whether to enable crypto and TLS... whatever
checking deprecated option for OpenSSL library path... auto
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking which TLS library to use... whatever
checking whether to use system crypto profile... no
checking deprecated option for whether to use system crypto profile... no

This skips all of the AS_IF branches in CheckSSL.m4 and simply hits the following:

AC_MSG_CHECKING([which TLS library to use])
AC_MSG_RESULT([$PHP_MONGODB_SSL])

@jmikola jmikola requested a review from derickr January 22, 2018 23:26
Copy link
Contributor

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This addresses test failures when the driver is compiled without SSL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants