Added the error message to the failure cases. #76
Conversation
This makes it much easier to debug what goes wrong, en-masse.
|
Could you have it trim newlines? |
|
lgtm after that |
| } | ||
| return $e->getMessage(); | ||
| } | ||
| printf("OK: Got %s\n", $exceptionname); | ||
| } else { | ||
| printf("ALMOST: Got %s - expected %s\n", get_class($e), $exceptionname); | ||
| printf("ALMOST: Got %s - expected %s: %s\n", get_class($e), $exceptionname, $e->getMessage()); |
There was a problem hiding this comment.
No ... That will only trim trailing new lines, not in the middle of the message
There was a problem hiding this comment.
What components are creating messages with newlines (not sure I've seen those before).
And a second question: is this just to allow %s in EXPECTF blocks, instead of requiring multi-line catch-alls?
There was a problem hiding this comment.
SSL, SASL, and I think mongoc compounds some error message somewhere, although its been a while so maybe not.
Its about being all in one line yes, so you can differentiate what is coming from what in the output.
This makes it much easier to debug what goes wrong, en-masse. In my case, I already found a "FIXME ADD EXCEPTION" instead of having to debug what the f goes on :-)