Allow for PHONGO-SERVERS.json in ~ (and fix a test case name) #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $FILENAME = sys_get_temp_dir() . "/PHONGO-SERVERS.json"; | ||
| if (file_exists("{$_SERVER['HOME']}/PHONGO-SERVERS.json")) { | ||
| $FILENAME = "{$_SERVER['HOME']}/PHONGO-SERVERS.json"; |
There was a problem hiding this comment.
That feels a littlebit dodge. Like the idea though
How about environment variable? PHONGO_SERVERS=/path/to/PHONGO-SERVERS.json
There was a problem hiding this comment.
Pushed a new commit for that.
derickr
force-pushed
the
test-name-and-servers
branch
from
0ac19ff to
1b2f920
Compare
bjori
added a commit
to bjori/mongo-php-driver
that referenced
this pull request
Aug 20, 2015
Allow for PHONGO-SERVERS.json in ~ (and fix a test case name) * derickr/test-name-and-servers: Do this with an env var instead Allow for PHONGO-SERVERS.json in ~ (and fix a test case name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.