Skip to content

Conversation

derickr
Copy link
Contributor

@derickr derickr commented Oct 11, 2018

No description provided.

@derickr derickr force-pushed the PHPC-1206-setstate-concerns branch 2 times, most recently from 4258502 to 6aa85d6 Compare October 11, 2018 17:04
@derickr derickr requested a review from jmikola October 11, 2018 17:04
@derickr derickr changed the title [WIP] PHPC-1206: Add __set_state() support for ReadConcern, ReadPreference, and WriteConcern PHPC-1206: Add __set_state() support for ReadConcern, ReadPreference, and WriteConcern Oct 11, 2018
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good. Just some questions about refactoring the init_from_hash functions and checking whether error messages are, or should be, consistent with their constructor equivalents.

@derickr derickr force-pushed the PHPC-1206-setstate-concerns branch from 6aa85d6 to 8ed9bc7 Compare October 19, 2018 14:09
@derickr derickr force-pushed the PHPC-1206-setstate-concerns branch from 8ed9bc7 to 9cbb01a Compare October 19, 2018 20:26
@derickr derickr merged commit 9cbb01a into mongodb:master Oct 19, 2018
derickr added a commit that referenced this pull request Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants