Fixed error when filename is not specified when reading file #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Jun 6, 2016
The Bucket's public API remains unchanged. More logic has been moved into the CollectionWrapper and the stream classes have also been renamed. The StreamWrapper's registration has been changed to allow a configurable protocol (Bucket defaults to "gridfs"). While file paths are generated for readable and writable streams (now in a more robust manner), necessary arguments are passed through context options. We may decide to simplify the path for readable streams down the line, unless the current path is beneficial for debugging. Closes mongodb#167
|
Thanks for the PR. This has been fixed with some refactoring in 46864db. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to read file with GridFS\Bucket::openDownloadStream() sub-method openDownloadStreamByFile() is directly accessing $file->filename property which is (according to https://docs.mongodb.org/manual/core/gridfs/#gridfs-collections) optional and is not needed for reading files from GridFS. This PR will fix error notice when this property is not set.