PHPLIB-1709: Test with PHP 8.5 #1781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
phplib-1709-test-php-8.5
branch
2 times, most recently
from
3776dce to
f9fa589
Compare
alcaeus
force-pushed
the
phplib-1709-test-php-8.5
branch
from
f9fa589 to
4fa2df4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for testing with PHP 8.5 by updating the CI configuration to include PHP 8.5 in the test matrix and enabling platform requirement ignoring for dependencies that may not yet support this version.
- Added PHP 8.5 to the test matrix in the GitHub Actions workflow
- Introduced a new input parameter to conditionally ignore platform requirements for PHP 8.5
- Updated the Composer installation step to skip platform requirements when testing with PHP 8.5
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/tests.yml | Added PHP 8.5 to test matrix and enabled platform requirement ignoring |
| .github/actions/setup/action.yml | Added ignore-platform-req input and updated composer options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
GromNaN
reviewed
Oct 6, 2025
| uses: ramsey/composer-install@3.0.0 | ||
| with: | ||
| composer-options: "--no-suggest" | ||
| composer-options: "--no-suggest ${{ inputs.ignore-platform-req == 'true' && '--ignore-platform-req=php+' || '' }}" |
There was a problem hiding this comment.
Do you need to keep this now that the driver version 2.1.2 supports PHP 8.5?
There was a problem hiding this comment.
This is needed because psalm does not support PHP 8.5 yet.
GromNaN
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-1709
Adds tests for PHP 8.5 to the CI pipeline.