PYTHON-3441 docs: add missed method in monitoring logger example #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxzhenzhera
requested review from
blink1073,
juliusgeo and
ShaneHarvey
as code owners
ShaneHarvey
approved these changes
Sep 19, 2022
ShaneHarvey
changed the title
|
Thanks @maxzhenzhera! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was researching how to log queries.
Found the
monitoringmodule with great examples.And found out that the example of ConnectionPoolLogger is missing one new method.
As a result of this -
NotImplementedErroron invocation of the method.So, I made a single commit to fix it.