PYTHON-3232 Improved change stream event visibility for C2C Replication #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
requested changes
Sep 26, 2022
ShaneHarvey
requested changes
Sep 26, 2022
| @@ -40,6 +40,7 @@ def __init__( | |||
| user_fields=None, | |||
| result_processor=None, | |||
| comment=None, | |||
| show_expanded_events=None, | |||
There was a problem hiding this comment.
Since you're implementing PYTHON-3232 in this PR can you rename the title and close PYTHON-3373 as a duplicate of PYTHON-3232?
juliusgeo
changed the title
|
Can you merge from master to pick up #1063? |
ShaneHarvey
requested changes
Sep 27, 2022
pymongo/change_stream.py
Outdated
| @@ -175,6 +177,10 @@ def _change_stream_options(self): | |||
|
|
|||
| if self._start_at_operation_time is not None: | |||
| options["startAtOperationTime"] = self._start_at_operation_time | |||
|
|
|||
| if self._show_expanded_events is True: | |||
There was a problem hiding this comment.
bools should be compared with if x: or if not x: not if x is True: or if x is False:
There was a problem hiding this comment.
What about truthy values?
>>> if 1:
... print("help")
...
help
There was a problem hiding this comment.
Yeah that's the point. if x works with anything truthy while if x is True doesn't. It's more verbose and less flexible.
There was a problem hiding this comment.
See
Don’t compare boolean values to True or False using ==:
# Correct:
if greeting:
# Wrong:
if greeting == True:
Worse:
# Wrong:
if greeting is True:
There was a problem hiding this comment.
Ah, ok. I was under the impression we would want less flexibility in this case.
ShaneHarvey
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.