Skip to content

PYTHON-1889 Single-source the version tuple/string #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2022
Merged

PYTHON-1889 Single-source the version tuple/string #1079

merged 2 commits into from
Oct 17, 2022

Conversation

blink1073
Copy link
Member

No description provided.

ShaneHarvey
ShaneHarvey approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but could you update the PR title/commit message to describe the change itself before merging?

@blink1073 blink1073 changed the title PYTHON-1889 Consider single-sourcing the version tuple/string PYTHON-1889 Single-source the version tuple/string Oct 17, 2022
@blink1073 blink1073 merged commit 942e281 into mongodb:master Oct 17, 2022
@blink1073 blink1073 deleted the PYTHON-1889 branch October 17, 2022 19:49
@blink1073
Copy link
Member Author

could you update the PR title/commit message to describe the change itself before merging?

Updated. Note: the commit message was already set to the PR title during squash and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@juliusgeo juliusgeo Awaiting requested review from juliusgeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @ShaneHarvey