PYTHON-2993 Deprecate MongoClient read only config option helpers and add client.options #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Oct 25, 2022
| @@ -14,27 +14,22 @@ | |||
|
|
|||
| Raises :class:`~pymongo.errors.InvalidName` if an invalid database name is used. | |||
|
|
|||
| .. autoattribute:: event_listeners | |||
There was a problem hiding this comment.
The deprecated helpers should still be documented but we should move them to the bottom with all the others. Any reason you removed them?
There was a problem hiding this comment.
Was trying to reduce visibility, will move to the bottom
| @@ -1142,22 +1146,33 @@ def max_pool_size(self): | |||
| ``waitQueueTimeoutMS`` is set, a blocked operation will raise | |||
| :exc:`~pymongo.errors.ConnectionFailure` after a timeout. | |||
| By default ``waitQueueTimeoutMS`` is not set. | |||
|
|
|||
| .. versionchanged:: 3.13 | |||
| Deprecated. Use ``client.options.pool_options.max_pool_size`` instead. | |||
There was a problem hiding this comment.
It would be nice to add the Use ``client.options.pool_options.max_pool_size`` instead to the warnings too.
ShaneHarvey
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.