PYTHON-3546 bson.CodecOptions docs missing unicode_decode_error_handler=ignore option in newer documentation #1131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er=ignore option in newer documentation
juliusgeo
approved these changes
Jan 5, 2023
ShaneHarvey
reviewed
Jan 10, 2023
There was a problem hiding this comment.
The diff weirdly shows the entire block being changed--not sure what's up with that
In diffs like this it's helpful to use the "ignore whitespace changes" setting (w=1): https://github.com/mongodb/mongo-python-driver/pull/1131/files?diff=split&w=1
| retrieved from the server will be modified in the client application | ||
| and stored back to the server. | ||
| """ | ||
| return super().__init__() |
There was a problem hiding this comment.
Don't we have to pass *args, **kwargs here?
There was a problem hiding this comment.
Ah, no, now I remember. namedtuple.__init__() "takes exactly one argument (the instance to initialize))". The args and kwargs are handled in __new__().
There was a problem hiding this comment.
Ah okay. That's not intuitive at all :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.