PYTHON-3803 add types to encryption.py #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Jul 10, 2023
| @@ -1025,9 +1025,21 @@ def encode( | |||
| return _dict_to_bson(document, check_keys, codec_options) | |||
|
|
|||
|
|
|||
| @overload | |||
| def decode(data: "_ReadableBuffer", codec_options: None = None) -> Dict[str, Any]: | |||
There was a problem hiding this comment.
Nice! This is great! I think we want to apply this same overload pattern throughout the codebase but I think that's too much for this PR. Could you open a new ticket for it? Eg decode_all, decode_iter, and anywhere else we use _DocumentType.
There was a problem hiding this comment.
sounds good, made the ticket
bson/raw_bson.py
Outdated
| @@ -62,7 +62,7 @@ | |||
|
|
|||
| def _inflate_bson( | |||
| bson_bytes: bytes, codec_options: CodecOptions, raw_array: bool = False | |||
| ) -> Mapping[Any, Any]: | |||
| ) -> MutableMapping[Any, Any]: | |||
ShaneHarvey
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PYTHON-3803