Skip to content

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 17, 2023

I also added coverage to the tasks that are run on PR commits

@blink1073 blink1073 requested a review from a team as a code owner October 17, 2023 11:43
@blink1073 blink1073 requested review from Jibola and removed request for a team October 17, 2023 11:43
@blink1073 blink1073 marked this pull request as draft October 17, 2023 13:02
@blink1073
Copy link
Member Author

evergreen retry

@blink1073 blink1073 marked this pull request as ready for review October 17, 2023 13:09
@blink1073 blink1073 closed this Oct 17, 2023
@blink1073 blink1073 reopened this Oct 17, 2023
Copy link
Contributor

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +261 to +262
# coverage 7.3 dropped support for Python 3.7, keep in sync with combine-coverage.sh.
python -m pip install pytest-cov "coverage<7.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we see a world where we have a version of python or dependent libraries that's incompatible with coverage<7.3? I don't imagine that's likely considering the python release schedules, and our support timelines but just curious.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, yes. We'll do a grep for Python 3.7 when we drop support for it, and should update this min version.

Comment on lines +19 to +20
pip list
ls -la coverage/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these two just for capturing the information in our logs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@blink1073 blink1073 merged commit fbf2937 into mongodb:master Oct 17, 2023
@blink1073 blink1073 deleted the PYTHON-4002 branch October 17, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants