PYTHON-4256 OIDC Spec Cleanup #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
blink1073
changed the title
…eturns error 18 resync specs fix connection string test Update prose tests
NoahStapp
requested changes
Apr 9, 2024
pymongo/auth_oidc.py
Outdated
| except Exception: # noqa: S110 | ||
| pass | ||
| except OperationFailure as e: | ||
| if e.code == 18: |
There was a problem hiding this comment.
Could these three mostly-duplicate code blocks be abstracted into a helper method that takes an appropriate callback to handle the error code 18 case?
There was a problem hiding this comment.
Callback seemed too awkward, but I made it into a validator.
| @@ -90,6 +90,9 @@ | |||
| # Server code raised when re-authentication is required | |||
| _REAUTHENTICATION_REQUIRED_CODE: int = 391 | |||
|
|
|||
| # Server code raised when authentication fails. | |||
| _AUTHENTICATION_FAILURE_CODE: int = 18 | |||
There was a problem hiding this comment.
Use this constant instead of the magic number 18 in auth_oidc?
test/auth_oidc/test_auth_oidc.py
Outdated
| @@ -53,7 +53,7 @@ | |||
| TOKEN_FILE = os.environ.get("OIDC_TOKEN_FILE", "") | |||
|
|
|||
| # Generate unified tests. | |||
| globals().update(generate_test_classes(str(TEST_PATH), module=__name__)) | |||
| # globals().update(generate_test_classes(str(TEST_PATH), module=__name__)) | |||
test/auth_oidc/test_auth_oidc.py
Outdated
| def create_request_cb(self, username="test_user1", sleep=0): | ||
| def request_token(context): | ||
| # Validate the info. | ||
| self.assertIsInstance(context.idp_info.issuer, str) | ||
| self.assertIsInstance(context.idp_info.clientId, str) | ||
| # self.assertIsInstance(context.idp_info.clientId, str) |
| uri = "mongodb+srv://example.com?authMechanism=MONGODB-OIDC&authMechanismProperties=ALLOWED_HOSTS:%5B%22example.com%22%5D" | ||
| with self.assertRaises(ConfigurationError), warnings.catch_warnings(): | ||
| warnings.simplefilter("ignore") | ||
| _ = MongoClient( |
There was a problem hiding this comment.
Pointless assignment just for the linter?
NoahStapp
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires mongodb-labs/drivers-evergreen-tools#428