Skip to content

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 marked this pull request as ready for review April 1, 2024 17:00
@blink1073
Copy link
Member Author

Windows failure is expected pending: https://jira.mongodb.org/browse/DEVPROD-5919

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot requested a review from Jibola April 1, 2024 17:02
@blink1073 blink1073 requested review from NoahStapp and removed request for Jibola April 1, 2024 17:02
Copy link
Contributor

@NoahStapp NoahStapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few clarifying questions, otherwise looks great!

export OIDC_ADMIN_USER=$OIDC_ATLAS_USER
export OIDC_ADMIN_PWD=$OIDC_ATLAS_PASSWORD
set -x
source ${DRIVERS_TOOLS}/.evergreen/auth_oidc/secrets-export.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing change, so much cleaner.

@blink1073 blink1073 requested a review from NoahStapp April 1, 2024 17:41
@blink1073 blink1073 changed the title DRIVERS-2878 OIDC Atlas Testing Updates PYTHON-4309 OIDC Atlas Testing Updates Apr 1, 2024
@blink1073 blink1073 merged commit bce047d into mongodb:master Apr 1, 2024
@blink1073 blink1073 deleted the DRIVERS-2878 branch April 1, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants