PYTHON-4300 Forward comment argument in list_search_indexes #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Apr 1, 2024
test/test_index_management.py
Outdated
| # Create a new search index on ``coll0`` that implicitly passes its type. | ||
| search_definition = {"mappings": {"dynamic": False}} | ||
| implicit_search_resp = coll0.create_search_index( | ||
| model={"name": _NAME + "-implicit", "definition": search_definition} |
There was a problem hiding this comment.
can you test adding a comment to this call too?
test/test_index_management.py
Outdated
| self.assertEqual(event.command["comment"], "foo") | ||
|
|
||
|
|
||
| class TestSearchIndexProse(TestSearchIndexIntegration): |
There was a problem hiding this comment.
If this subclasses TestSearchIndexIntegration then won't test_comment_field accidentally run twice?
There was a problem hiding this comment.
Created a new base class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.