PYTHON-4610 More robust to_list tests #1773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
commented
Aug 6, 2024
| @async_client_context.require_replica_set | ||
| async def test_to_list_tailable(self): | ||
| oplog = self.client.local.oplog.rs | ||
| last = await oplog.find().sort("$natural", pymongo.DESCENDING).limit(-1).next() | ||
| ts = last["ts"] | ||
|
|
||
| # Set maxAwaitTimeMS=1 to speed up the test and avoid blocking on the noop writer. |
There was a problem hiding this comment.
maxAwaitTimeMS defaults to 1000, which gives the noop writer a chance to write a document to the oplog. What happens is the to_list call repeatedly calls getMore which blocks for 1 second and returns 1 noop document each time. That's why the test was sometimes taking 20+ seconds.
NoahStapp
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHON-4610