Skip to content

PYTHON-4574 - FaaS detection logic mistakenly identifies EKS as AWS Lambda #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2024
Merged

PYTHON-4574 - FaaS detection logic mistakenly identifies EKS as AWS Lambda #1908

merged 2 commits into from
Oct 15, 2024

Conversation

NoahStapp
Copy link
Contributor

No description provided.

@ShaneHarvey
Copy link
Member

What about cases where a container is deployed on AWS Lambda? https://docs.aws.amazon.com/lambda/latest/dg/images-create.html

@NoahStapp
Copy link
Contributor Author

NoahStapp commented Oct 9, 2024 •
edited
Loading

What about cases where a container is deployed on AWS Lambda? docs.aws.amazon.com/lambda/latest/dg/images-create.html

If the correct environment variables are present for both AWS Lambda and a container, we'd need to decide what the correct result is.

I don't know if it's possible to distinguish between AWS Lambda running inside a container and a container deployed on AWS Lambda from our end. Would we expect that AWS Lambda -> Container displays only Lambda metadata? Both metadatas? If our expectation is that Container -> AWS Lambda only displays container metadata, I would expect Lambda -> Container to display only Lambda metadata.

@NoahStapp NoahStapp mentioned this pull request Oct 9, 2024
Merged
@ShaneHarvey
Copy link
Member

Let's move this convo to the drivers ticket/PR.

@NoahStapp NoahStapp marked this pull request as ready for review October 11, 2024 14:57
blink1073
blink1073 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

caseyclements
caseyclements approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoahStapp NoahStapp merged commit 872fda1 into mongodb:master Oct 15, 2024
36 checks passed
@NoahStapp NoahStapp deleted the PYTHON-4574 branch October 15, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyclements caseyclements caseyclements approved these changes

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NoahStapp @ShaneHarvey @caseyclements @blink1073