PYTHON-4903 Adds typing overloading to bson.binary.Binary.from_vector #1967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
requested changes
Oct 24, 2024
ShaneHarvey
requested changes
Oct 25, 2024
ShaneHarvey
requested changes
Nov 4, 2024
test/test_bson.py
Outdated
| @@ -802,6 +802,13 @@ def test_vector(self): | |||
| assert float_binary == Binary.from_vector( | |||
| BinaryVector(list_vector, BinaryVectorDtype.FLOAT32) | |||
| ) | |||
| # Confirm kwargs cannot be passed when BinaryVector is provided | |||
| self.assertRaises( | |||
There was a problem hiding this comment.
Can you write this as a with self.assertRaises(): so we can confirm a "type-ignore" is detected?
There was a problem hiding this comment.
Sure can. How do we confirm that a type-ignore is detected?
with self.assertRaises(ValueError):
Binary.from_vector(
BinaryVector(list_vector, BinaryVectorDtype.PACKED_BIT, padding),
dtype=BinaryVectorDtype.PACKED_BIT
)
There was a problem hiding this comment.
Oh.... I see. This will fail linting without it.
There was a problem hiding this comment.
Yep that's what I was thinking!
There was a problem hiding this comment.
TIL. Thanks @ShaneHarvey ! This was a very cool lesson.
… incorrect signature with [call-overload]
ShaneHarvey
approved these changes
Nov 5, 2024
blink1073
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows suggestion from @ShaneHarvey that adding typing oveloading would make clear that dtype is a required argument when the first argument, vector, is a list, not at BinaryVector instance.