Skip to content

PYTHON-4807 - Specify how to handle unacknowledged+(ordered|verbose|m… #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

NoahStapp
Copy link
Contributor

…ulti-batch) bulk writes

@NoahStapp NoahStapp requested a review from blink1073 October 29, 2024 14:35
@blink1073
Copy link
Member

Needs some None checks:

"Optional[WriteConcern]" has no attribute "acknowledged"  [union-attr]
            if not write_concern.acknowledged and verbose_results:

@NoahStapp
Copy link
Contributor Author

Needs some None checks:

"Optional[WriteConcern]" has no attribute "acknowledged"  [union-attr]
            if not write_concern.acknowledged and verbose_results:

Whoops :yikes:

@blink1073
Copy link
Member

Needs the prose test: mongodb/specifications@c84488c#diff-9de75f337c20e76dc80a4e133a38583f9249c04f3348591c61cda4b393c74655R699

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoahStapp NoahStapp merged commit 2f1227c into mongodb:master Oct 29, 2024
34 of 35 checks passed
@NoahStapp NoahStapp deleted the PYTHON-4807 branch October 29, 2024 16:28
"Cannot request unacknowledged write concern and verbose results"
)
elif write_concern and not write_concern.acknowledged and ordered:
raise InvalidOperation("Cannot request unacknowledged write concern and ordered writes")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be some dead code we can remove now that we don't support these operations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants