PYTHON-3096 & PYTHON-2867 Implement GSSAPI ServiceHost support and expand canonicalization options #1983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
approved these changes
Oct 30, 2024
blink1073
changed the title
ShaneHarvey
reviewed
Oct 30, 2024
| @@ -78,7 +78,7 @@ def __hash__(self) -> int: | |||
|
|
|||
|
|
|||
| GSSAPIProperties = namedtuple( | |||
| "GSSAPIProperties", ["service_name", "canonicalize_host_name", "service_realm"] | |||
| "GSSAPIProperties", ["service_name", "canonicalize_host_name", "service_realm", "service_host"] | |||
There was a problem hiding this comment.
It doesn't look like we actually do anything with service_host. Why add it if it's not used?
There was a problem hiding this comment.
Argh, I made the changes in the synchronous files and they got wiped out! I'll make a follow up PR tomorrow.
| @@ -87,6 +87,16 @@ def __hash__(self) -> int: | |||
| """Mechanism properties for MONGODB-AWS authentication.""" | |||
|
|
|||
|
|
|||
| def _validate_canonicalize_host_name(value: str | bool) -> str | bool: | |||
| valid_names = [False, True, "none", "forward", "forwardAndReverse"] | |||
There was a problem hiding this comment.
So "none", "forward", and "forwardAndReverse" are all supposed to be treated the same as True? Is that accurate?
There was a problem hiding this comment.
No, you'll see in the follow up PR how they're used in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.