PYTHON-4977 Fix import time on Windows again #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added an import time check on Windows. Also I relized the import time check is pretty easy to miss because it will only fail once on the PR and once on the slow commit, and the it will pass on all commits after that. The only way I can think to avoid that problem is to use a known good version as the reference point and keep it fixed. I'll open a new ticket for that idea. |
|
Okay rereading the original ticket, it turns out we can't reproduce the slow import on our Windows hosts anyway so I've removed the windows import check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHON-4977 Fix import time on Windows again
In #1678 we accidentally reverted the fix for PYTHON-4455.