PYTHON-5543 PyMongoBaseProtocol should inherit from asyncio.BaseProtocol #2528
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import and use BaseProtocol instead of Protocal in PyMongoBaseProtocoal implementation. Resolves issue with instance type check in uvloop that prevents correct buffered config from being set.
NoahStapp
requested changes
Sep 11, 2025
doc/changelog.rst
Outdated
| Version 4.15.1 is a bug fix release. | ||
|
|
||
| - Fixed a bug in ``MongoClient.network_layer`` and ``AsyncMongoClient.network_layer`` | ||
| that could cause an ``TimeoutError`` when connecting to servers. |
There was a problem hiding this comment.
We don't need to call out that the bug was in network_layer. We do need to call out that it was a bug with AsyncMongoClient, and only with uvicorn and uvloop.
There was a problem hiding this comment.
OK I'll fix, what about the difference between PYTHON-5543 and PYTHON-5544? I couldn't reproduce for PYTHON-5543 because the reproducer was incomplete. Should we assume some use of uvicorn with FastAPI?
There was a problem hiding this comment.
I closed PYTHON-5543 as a duplicate. Let me know if that's incorrect.
There was a problem hiding this comment.
uvicorn defaults to uvloop under the hood.
ShaneHarvey
reviewed
Sep 11, 2025
|
drivers-pr-bot please backport to v4.15 |
aclark4life
changed the title
NoahStapp
previously requested changes
Sep 11, 2025
Co-authored-by: Noah Stapp <noah@noahstapp.com>
ShaneHarvey
approved these changes
Sep 11, 2025
aclark4life
added a commit
to aclark4life/mongo-python-driver
that referenced
this pull request
Sep 11, 2025
…col (mongodb#2528) Co-authored-by: Noah Stapp <noah@noahstapp.com>
aclark4life
added a commit
to aclark4life/mongo-python-driver
that referenced
this pull request
Sep 11, 2025
…col (mongodb#2528) Co-authored-by: Noah Stapp <noah@noahstapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseProtocolinstead ofProtocolinPyMongoBaseProtocolimplementation added in PYTHON-5215.