Skip to content

Conversation

sleepyStick
Copy link
Contributor

@sleepyStick sleepyStick commented Sep 23, 2025

Summary

It's been difficult to spot trends since these tasks run weekly. All but OSCP can run daily.
https://jira.mongodb.org/browse/PYTHON-5563

Changes in this PR

  • Made a variable for BATCHTIME_DAY
  • re-generated the variants using BATCHTIME_DAY

Test Plan

Screenshots (optional)

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
    (not necessary i think)
  • Is the intention of the code captured in relevant tests?
  • If there are new TODOs, has a related JIRA ticket been created?

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Have you checked for spelling & grammar errors?
  • Is all relevant documentation (README or docstring) updated?

Focus Areas for Reviewer

That the correct variants run daily and the actual value of BATCHTIME_DAY is correct.

ALL_PYTHONS = CPYTHONS + PYPYS
MIN_MAX_PYTHON = [CPYTHONS[0], CPYTHONS[-1]]
BATCHTIME_WEEK = 10080
BATCHTIME_DAY = 1440
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is number is supposed to be minutes a day

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, "the interval of time (in minutes) that Evergreen should wait in between activating the latest version."

@sleepyStick sleepyStick marked this pull request as ready for review September 24, 2025 16:40
@sleepyStick sleepyStick requested a review from a team as a code owner September 24, 2025 16:40
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sleepyStick sleepyStick merged commit 4849eac into mongodb:master Sep 24, 2025
75 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants