Skip to content

Conversation

kay-kim
Copy link
Contributor

@kay-kim kay-kim commented Jul 27, 2017

Need to check python 2.6 for the date

@ShaneHarvey
Copy link
Member

Works fine on 2.6:

$ python2.6
Python 2.6.9 (unknown, Feb  7 2017, 00:08:08)
[GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.34)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import datetime
>>> u'2008-{0}'.format(datetime.date.today().year)
'2008-2017'

doc/conf.py Outdated
@@ -28,7 +30,7 @@

# General information about the project.
project = u'PyMongo'
copyright = u'2008 - 2015, MongoDB, Inc.'
copyright = u'2008-{0}'.format(datetime.date.today().year)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever. Can you add back the ", MongoDB, Inc."? Overwise the bottom of the page just says "© Copyright 2008-2017. Created using Sphinx 1.4.5."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Will do.


{%- block extrahead %}

{% if theme_googletag %}
Copy link
Member

@ShaneHarvey ShaneHarvey Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't theme_googletag always false? What's the point of adding this if it's never included?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to Bernie and he pointed out that we want the default to be false. It doesn't make sense for local docs builds to include it.

We'll only enable this for the production builds on http://api.mongodb.com/python.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we build from apidocs, we'll flipt to true. This way, people can clone this repo and it won't be on whereas when we build for api.mongodb.com, it will be on and we can track.

@kay-kim
Copy link
Contributor Author

kay-kim commented Jul 27, 2017

FYI -- @ShaneHarvey / @behackett -- I updated the copyright to be consistent with the docs (the docs' copyright blurb was what Todd the legal guy had asked us to do last year) -- I suppressed the Sphinx build blurb, but can put it back if you all want it in there.

Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kay-kim
Copy link
Contributor Author

kay-kim commented Aug 1, 2017

@ShaneHarvey / @behackett -- no hurry on my end. Just a note to make sure you all haven't forgotten about this pull request. If you haven't, feel free to ignore my comment :D

@ShaneHarvey ShaneHarvey merged commit aa7a40c into mongodb:master Aug 1, 2017
@ShaneHarvey
Copy link
Member

Thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants