-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: add google tag #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add google tag #331
Conversation
Works fine on 2.6:
|
doc/conf.py
Outdated
@@ -28,7 +30,7 @@ | |||
|
|||
# General information about the project. | |||
project = u'PyMongo' | |||
copyright = u'2008 - 2015, MongoDB, Inc.' | |||
copyright = u'2008-{0}'.format(datetime.date.today().year) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever. Can you add back the ", MongoDB, Inc."
? Overwise the bottom of the page just says "© Copyright 2008-2017. Created using Sphinx 1.4.5."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Will do.
|
||
{%- block extrahead %} | ||
|
||
{% if theme_googletag %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't theme_googletag
always false? What's the point of adding this if it's never included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked to Bernie and he pointed out that we want the default to be false. It doesn't make sense for local docs builds to include it.
We'll only enable this for the production builds on http://api.mongodb.com/python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we build from apidocs, we'll flipt to true. This way, people can clone this repo and it won't be on whereas when we build for api.mongodb.com, it will be on and we can track.
FYI -- @ShaneHarvey / @behackett -- I updated the copyright to be consistent with the docs (the docs' copyright blurb was what Todd the legal guy had asked us to do last year) -- I suppressed the Sphinx build blurb, but can put it back if you all want it in there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ShaneHarvey / @behackett -- no hurry on my end. Just a note to make sure you all haven't forgotten about this pull request. If you haven't, feel free to ignore my comment :D |
Thanks for the reminder! |
Need to check python 2.6 for the date