GridFS.delete returns DeleteResult

[drhagen]

pymongo.Collection.delete_one returns a DeleteResult object which, among other things, provides the deleted_count attribute telling whether or not anything was actually deleted by the call. However, gridfs.GridFS.delete returns nothing regardless if a document is deleted. This PR changes the behavior of GridFS to more closely follow Collection by returning the DeleteResult from the underlying call to delete the document index.

[ShaneHarvey]

Thanks for the pull. The implementation seems fine but GridFs is pymongo's old API for gridfs. GridFSBucket is the new API which is implemented according to the GridFS spec.

The newer GridFSBucket.delete method raises a NoFile exception when the file does not exist. May I suggest using the newer API instead because it already supports your use-case?

[ShaneHarvey]

Hi @drhagen, we have decided not to add this feature to the old GridFS api because the newer GridFSBucket.delete method already supports it. Please let us know if you have any issues using GridFSBucket:

import gridfs
my_db = MongoClient().test
fs = gridfs.GridFSBucket(my_db)
try:
    fs.delete(file_id)
except gridfs.errors.NoFile:
    # file_id did not exist.
    pass