PYTHON-2295 MongoClient with multiple hosts directConnection=True should raise an error #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctConnection=True should raise an error
ShaneHarvey
reviewed
Jun 26, 2020
pymongo/mongo_client.py
Outdated
| @@ -624,7 +624,7 @@ def __init__( | |||
| username = None | |||
| password = None | |||
| dbase = None | |||
| opts = {} | |||
| opts = common._CaseInsensitiveDictionary() | |||
There was a problem hiding this comment.
Is this needed? We already seem to use _CaseInsensitiveDictionary for keyword_opts down on line 663.
test/test_client.py
Outdated
| for h, p in nodes: | ||
| hosts.append("%s:%s" % (h, p)) | ||
| with self.assertRaises(ConfigurationError): | ||
| MongoClient(hosts, directConnection=True) |
There was a problem hiding this comment.
I think we can use multiple hosts without caring whether they exist or not (since we'll raise an error before attempting to connect). So we could reduce this to:
with self.assertRaises(ConfigurationError):
MongoClient(['host1', 'host2'], directConnection=True)
ShaneHarvey
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.