PYTHON-2082 Unpin session after RetryableWriteErrors from commitTransaction #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHON-2154 PYTHON-2189 Remove 4.5 transaction test workarounds
Explanation: The StaleConfig change in PYTHON-2189 accidentally causes the test_transactions suite to ignore any failed test because there was a missing
raise
statement. Now that we're no longer masking test failures, this test began to fail:This test failure is caused by PYTHON-2082. In particular, we neglected to unpin the session on retryable commitTransaction errors. To fix the bug we unpin the session on all errors with the RetryableWriteError label.
I've already tested this change here: https://evergreen.mongodb.com/version/5efb9809c9ec447c47b57365