PYTHON-2474 Fix non-disabled client_knobs bug in Data Lake tests #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
commented
Dec 22, 2020
| def setUpClass(cls): | ||
| super(DataLakeTestSpec, cls).setUpClass() | ||
| # Skip these tests unless connected to data lake. | ||
| if not client_context.is_data_lake: | ||
| raise unittest.SkipTest('Not connected to Atlas Data Lake') |
There was a problem hiding this comment.
Explanation:
- The super class' setUpClass method calls client_knobs.enable().
- Here we raise SkipTest
- tearDownClass is never called because setUpClass raised an error.
- The side-effects of client_knobs are still present.
The change here fixes the bug by raising SkipTest before calling setUpClass.
prashantmital
approved these changes
Dec 22, 2020
ShaneHarvey
added a commit
that referenced
this pull request
Dec 22, 2020
(cherry picked from commit 2eecf52)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.