PYTHON-2631 Add missing error message to InvalidBSON error #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behackett
reviewed
Apr 2, 2021
bson/_cbsonmodule.c
Outdated
| PyObject* InvalidBSON = _error("InvalidBSON"); | ||
| if (InvalidBSON) { | ||
| PyErr_SetNone(InvalidBSON); | ||
| PyErr_SetString(InvalidBSON, "invalid field name"); |
There was a problem hiding this comment.
Done. I went with "field name too large". This can happen when the BSON itself gets corrupted or mangled. For example the null terminator was overwritten or the field was internally truncated like in the test case below.
behackett
approved these changes
Apr 2, 2021
ShaneHarvey
added a commit
to ShaneHarvey/mongo-python-driver
that referenced
this pull request
Apr 19, 2021
(cherry picked from commit cc029a1)
ShaneHarvey
added a commit
to ShaneHarvey/mongo-python-driver
that referenced
this pull request
Apr 19, 2021
(cherry picked from commit cc029a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PYTHON-2631